Paths for trips #724
Merged
Paths for trips #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freika
force-pushed
the
feature/tracks
branch
from
fc4a272 to
5bd6a6c
Compare
gboudreau
reviewed
Jan 30, 2025
|
|
||
| class AddPathToTrips < ActiveRecord::Migration[8.0] | ||
| def change | ||
| add_column :trips, :path, :line_string, srid: 3857 |
There was a problem hiding this comment.
I don't think 3857 is the correct value to use. I think it should be 4326.
Ref: https://gis.stackexchange.com/a/380296/55872
Not sure it matters right now (i.e. it probably works with 3857 too for now), but it might cause issues later, if you try to use PostGIS functions like ST_Contains().
There was a problem hiding this comment.
I'm not an expert in GIS, but I did my small research and came to a conclusion that 3857 serves well in case of flat planar projections, specifically for web mapping. But as I said, not an expert, so if you could provide pro/contra for 4326, I may consider changing it in the future. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed